Is there a way? Currently, no. Is there a way to add it? Yes, anything is possible with programming. One could modify the code to find youtube links and convert them into embedded videos.

NNF doesn't embed pictures or videos because of easy abuse by anonymous users. One your forum, do you expect the public to be posting videos, or your moderators? It wouldn't be unrealistic to allow moderators to embed pictures and videos, and I would consider that feature, but it's not sensible to allow anonymous users to do that.

Nice code example Johann, that would be very easy to plug in to the `formatText` function :)

@ms: It goes into the lib/functions.php file, but I've tried this code out and it doesn't work because the YouTube hyperlink is being double-processed (once as a video and once as a normal hyperlink) -- producing invalid HTML. It'll need a bit more adaptation to work properly but I can't really help with that right this moment (brand new baby!)

When I come around to implementing this myself there won't be any bbcode markup; any YouTube URL on its own line will be turned into an embed. What we'll need to do to handle more complex markup like this is replace the YouTube HTML tags with placeholders (as we already do with PRE blocks) before doing any further processing.

> What we'll need to do to handle more complex markup like this is replace the YouTube HTML tags with placeholders (as we already do with PRE blocks) before doing any further processing.

Can’t the YouTube regex be run after the link regex? Then you can just write the regex to check for any P element containing only a single A element linking to YouTube (or any other video platform). That sounds possible and not too complex. Of course I haven’t worked with the NNF regex for a while so I could be off. Maybe I’ll look into it tonight.

Else we can try not to mess with the NNF source code and write a DOMTemplate extension for the `theme_custom` function, much like I have previously done for gravatars: https://gist.github.com/Zegnat/4088332

@ms, no. I guess it could be made to do something like that though. It just puts a Gravatar in-front of the user name – meaning it only works when people use their email address as name. There is a long-standing issue over at Github about implementing hooks for saving extra user data (e.g. email addresses): https://github.com/Kroc/NoNonsenseForum/issues/156.

With time anything could be build ;-)

@Johann, that’s true. But I think the beauty of @Kroc’s idea is that it takes the ‘YouTube URL on its own line’. How often have you written an link with no punctuation or other text on an empty line when you only want to link it? Normally when the purpose is to give just a link this will be within text.

Having NNF display avatars by requesting an image with the same name as the user is very possible. Although I would advice using some sort of alpha-numerical digest of the user name, because NNF supports a lot of different symbols in the name that might upset your server OS.

The problem is allowing people to upload these images. NNF does not have any sort of control panel for such an action so you will have to invent one. That pretty much means starting from scratch on a control panel.

@ms, sure, you could even repurpose my original script into something like:

%
/* Put this in theme.php, inside the `theme_custom` function. */
 
	foreach ($template->query('.nnf_reply-author, #nnf_post-author') as $node) {
		$value = '<img src="/avatar/' . md5(trim($node->nodeValue)) . '.png" alt="" /> '
		       . $node->nodeValue;
		$node->nodeValue = '';
		$frag = $node->ownerDocument->createDocumentFragment();
		if (!@$frag->appendXML($value) || !@$node->appendChild($frag)) {
			throw new Exception("Invalid HTML");
		}
	}
%

This should (untested) put an IMG infront of each name showing a PNG file in the avatars directory with an md5 hash of the user name as its filename. Someone with the name ‘ms’ would get `ee33e909372d935d190f4fcb2a92d542.png` infront of their name.

Note that you might want to put in a check `if` such a `file_exists` or you are going to get a lot of 404 hits against your server.

Haven’t had the time yet to get around to a DOMTemplate function for YouTube embedding. Soon, I hope.

Just like the above avatar code, this goes into your `theme.php` file and then in the `theme_custom` function. This was specifically catered to the Greyscale theme. It replaces YouTube links (the different ones I could think of, at least) into actual YouTube embeds if they are the only thing on a line.

It also replaces URLs to images into `IMG` elements. Not because it was requested but because I wanted to show how you could extend both the regular expression and the `if`s to allow other type of links to be replaced. E.g. you could adapt it to embed tweets or other video services.

%
foreach ($template->query('//article/div/p[a and count(*)=1 and not(normalize-space(text()))]') as $node) {
		$link = trim($node->nodeValue);
		$replace = false;

		if (
			preg_match('~(?:
				https?://(?:www\.)?youtu(?:be\.com/(?:embed/|watch\?(?:.+&)?v=)|\.be/)([a-z0-9_\-]+) # Parsing YouTube URLs.
				|
				(.+\.(?:png|jpe?g|gif)) # Parsing image URLs.
			)~ixA', $link, $matches)
		) {
			if (strlen($matches[1])) { // We found a YouTube video.
				$replace = '<iframe width="480" height="360" src="http://www.youtube-nocookie.com/embed/' . $matches[1] . '?autoplay=0&amp;rel=0" frameborder="0" allowfullscreen="allowfullscreen">' . safeHTML($link) . '</iframe>';
			} else if (strlen($matches[2])) { // We found an image link.
				$replace = '<a href="' . safeHTML($link) . '"><img src="' . $matches[2] . '" alt="' . safeHTML($link) . '" /></a>';
			}
		}

		if ($replace) {
			$frag = $node->ownerDocument->createDocumentFragment();
			if (!@$frag->appendXML($replace) || !@$node->parentNode->replaceChild($frag, $node)) {
				throw new Exception("Invalid HTML");
			}
		}
	}
%

There are probably problems with this. I’ve only done minor testing. And you will need to change your CSS yourself if you want anything special.

Note: this is a *template* modifier and runs on the HTML given to the browser. Inside your RSS you will still be seeing the normal URL.

:: @Martijn added on 11 Jul ’13 · 22:08

I think I made a small mistake. Change this:

% Original line #9
				(.+\.(?:png|jpe?g|gif)) # Parsing image URLs.
%

Into this:

% New line #9
				(.+\.(?:png|jpe?g|gif)$) # Parsing image URLs.
%

Guess I should invest in a good Regex editor sometime soon, as soon as I have the cash. Something like http://brettterpstra.com/2013/07/01/mac-app-review-oyster/. Anyone know any good free alternatives?

“u just made me a very thankful person!”

Just send me a copy of Oyster ;-) No, just kidding.

I hope you have some use for it, and please do let me know if you run into any problems. Maybe I’ll make it into a gist soon so I can keep track of updates and start adding more services, but as I’m currently not employing NNF for anything big I don’t know if I’ll get around to it or not.

This did have the nice side-effect of resulting in a possible fix for DOMTemplate’s `iframe` support: https://github.com/Kroc/DOMTemplate/pull/20. So there’s that :D